diff options
author | Denys Vlasenko <vda.linux@googlemail.com> | 2016-07-06 21:58:02 +0200 |
---|---|---|
committer | Denys Vlasenko <vda.linux@googlemail.com> | 2016-07-06 21:58:02 +0200 |
commit | 237bedd499c58034a1355484d6d4d906f0180308 (patch) | |
tree | 42a789f8867ba3bc6ef0cea30fb18f5553d447a0 /mailutils | |
parent | 0844b5afe2cd60d46b7f2ad0fac8c2818d0780b3 (diff) | |
download | busybox-237bedd499c58034a1355484d6d4d906f0180308.tar.gz |
getopt32: add new syntax of 'o:+' and 'o:*' for -o NUM and -o LIST
In many cases, this aqllows to drop use of opt_complementary.
Approximately -400 bytes:
function old new delta
getopt32 1423 1502 +79
opt_string 17 18 +1
OPT_STR 24 25 +1
uniq_main 416 406 -10
timeout_main 279 269 -10
sulogin_main 270 260 -10
readprofile_main 1825 1815 -10
ps_main 543 533 -10
pidof_main 245 235 -10
pgrep_main 611 601 -10
od_main 2600 2590 -10
mkfs_minix_main 2684 2674 -10
mkfs_ext2_main 2603 2593 -10
microcom_main 712 702 -10
makemime_main 315 305 -10
ionice_main 282 272 -10
inetd_main 2074 2064 -10
ifplugd_main 1144 1134 -10
halt_main 353 343 -10
getopt_main 636 626 -10
fdisk_main 2854 2844 -10
env_main 206 196 -10
dmesg_main 319 309 -10
conspy_main 1214 1204 -10
awk_main 981 971 -10
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 3/22 up/down: 81/-220) Total: -139 bytes
text data bss dec hex filename
919373 906 14060 934339 e41c3 busybox_old
918969 906 14060 933935 e402f busybox_unstripped
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'mailutils')
-rw-r--r-- | mailutils/makemime.c | 3 | ||||
-rw-r--r-- | mailutils/popmaildir.c | 4 | ||||
-rw-r--r-- | mailutils/reformime.c | 4 | ||||
-rw-r--r-- | mailutils/sendmail.c | 4 |
4 files changed, 7 insertions, 8 deletions
diff --git a/mailutils/makemime.c b/mailutils/makemime.c index 1dadd715f..8e1bc664c 100644 --- a/mailutils/makemime.c +++ b/mailutils/makemime.c @@ -184,9 +184,8 @@ int makemime_main(int argc UNUSED_PARAM, char **argv) INIT_G(); // parse options - opt_complementary = "a::"; opts = getopt32(argv, - "c:e:o:C:N:a:", // "m:j:", + "c:e:o:C:N:a:*", // "m:j:", &content_type, NULL, &opt_output, &G.opt_charset, NULL, &opt_headers //, NULL, NULL ); //argc -= optind; diff --git a/mailutils/popmaildir.c b/mailutils/popmaildir.c index 62030331e..69eca6164 100644 --- a/mailutils/popmaildir.c +++ b/mailutils/popmaildir.c @@ -107,9 +107,9 @@ int popmaildir_main(int argc UNUSED_PARAM, char **argv) INIT_G(); // parse options - opt_complementary = "-1:dd:t+:R+:L+:H+"; + opt_complementary = "-1:dd"; opts = getopt32(argv, - "bdmVcasTkt:" "R:Z:L:H:" IF_FEATURE_POPMAILDIR_DELIVERY("M:F:"), + "bdmVcasTkt:+" "R:+Z:L:+H:+" IF_FEATURE_POPMAILDIR_DELIVERY("M:F:"), &timeout, NULL, NULL, NULL, &opt_nlines IF_FEATURE_POPMAILDIR_DELIVERY(, &delivery, &delivery) // we treat -M and -F the same ); diff --git a/mailutils/reformime.c b/mailutils/reformime.c index 86b2cfed3..b967dfbc7 100644 --- a/mailutils/reformime.c +++ b/mailutils/reformime.c @@ -265,9 +265,9 @@ int reformime_main(int argc UNUSED_PARAM, char **argv) // parse options // N.B. only -x and -X are supported so far - opt_complementary = "x--X:X--x" IF_FEATURE_REFORMIME_COMPAT(":m::"); + opt_complementary = "x--X:X--x"; opts = getopt32(argv, - "x:X" IF_FEATURE_REFORMIME_COMPAT("deis:r:c:m:h:o:O:"), + "x:X" IF_FEATURE_REFORMIME_COMPAT("deis:r:c:m:*h:o:O:"), &opt_prefix IF_FEATURE_REFORMIME_COMPAT(, NULL, NULL, &G.opt_charset, NULL, NULL, NULL, NULL) ); diff --git a/mailutils/sendmail.c b/mailutils/sendmail.c index 5143fac8f..fb4dbb3da 100644 --- a/mailutils/sendmail.c +++ b/mailutils/sendmail.c @@ -247,11 +247,11 @@ int sendmail_main(int argc UNUSED_PARAM, char **argv) // parse options // -v is a counter, -H and -S are mutually exclusive, -a is a list - opt_complementary = "vv:w+:H--S:S--H:a::"; + opt_complementary = "vv:H--S:S--H"; // N.B. since -H and -S are mutually exclusive they do not interfere in opt_connect // -a is for ssmtp (http://downloads.openwrt.org/people/nico/man/man8/ssmtp.8.html) compatibility, // it is still under development. - opts = getopt32(argv, "tf:o:iw:H:S:a::v", &opt_from, NULL, + opts = getopt32(argv, "tf:o:iw:+H:S:a:*:v", &opt_from, NULL, &timeout, &opt_connect, &opt_connect, &list, &verbose); //argc -= optind; argv += optind; |