aboutsummaryrefslogtreecommitdiff
path: root/miscutils
diff options
context:
space:
mode:
Diffstat (limited to 'miscutils')
-rw-r--r--miscutils/last_fancy.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/miscutils/last_fancy.c b/miscutils/last_fancy.c
index f687d7e16..16ed9e920 100644
--- a/miscutils/last_fancy.c
+++ b/miscutils/last_fancy.c
@@ -42,7 +42,7 @@ enum {
static void show_entry(struct utmp *ut, int state, time_t dur_secs)
{
unsigned days, hours, mins;
- char duration[32];
+ char duration[sizeof("(%u+02:02)") + sizeof(int)*3];
char login_time[17];
char logout_time[8];
const char *logout_str;
@@ -53,7 +53,8 @@ static void show_entry(struct utmp *ut, int state, time_t dur_secs)
* but some systems have it wrong */
tmp = ut->ut_tv.tv_sec;
safe_strncpy(login_time, ctime(&tmp), 17);
- snprintf(logout_time, 8, "- %s", ctime(&dur_secs) + 11);
+ tmp = dur_secs;
+ snprintf(logout_time, 8, "- %s", ctime(&tmp) + 11);
dur_secs = MAX(dur_secs - (time_t)ut->ut_tv.tv_sec, (time_t)0);
/* unsigned int is easier to divide than time_t (which may be signed long) */