aboutsummaryrefslogtreecommitdiff
path: root/toys
diff options
context:
space:
mode:
authorHyejin Kim <hj8296@gmail.com>2015-03-15 19:29:15 -0500
committerHyejin Kim <hj8296@gmail.com>2015-03-15 19:29:15 -0500
commita9f4ec26c8594df7410fa0e22dd7044d9ac6d5c6 (patch)
tree40d20456b5927d2156cff79f184ee084db019fb9 /toys
parentd0bc1a39ef65fb2a726b2ff49ba29dbaa9a78aba (diff)
downloadtoybox-a9f4ec26c8594df7410fa0e22dd7044d9ac6d5c6.tar.gz
I added error handling code in write_rotate().
I think that it is better to check tf->logfd before doing truncate()/write() and getting error.
Diffstat (limited to 'toys')
-rw-r--r--toys/pending/syslogd.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/toys/pending/syslogd.c b/toys/pending/syslogd.c
index 7fb297f8..450bd72f 100644
--- a/toys/pending/syslogd.c
+++ b/toys/pending/syslogd.c
@@ -300,6 +300,10 @@ static int write_rotate(struct logfile *tf, int len)
unlink(tf->filename);
close(tf->logfd);
tf->logfd = open(tf->filename, O_CREAT | O_WRONLY | O_APPEND, 0666);
+ if (tf->logfd < 0) {
+ perror_msg("can't open %s", tf->filename);
+ return -1;
+ }
}
ftruncate(tf->logfd, 0);
}