diff options
| author | Denys Vlasenko <vda.linux@googlemail.com> | 2010-07-04 04:26:55 +0200 |
|---|---|---|
| committer | Denys Vlasenko <vda.linux@googlemail.com> | 2010-07-04 04:26:55 +0200 |
| commit | 243d1757d798a0cd43f51eb1db75cc1e81c65732 (patch) | |
| tree | 09bad361c80d75a46afcdea52a3f5debb61b8b4d | |
| parent | fd744519d1e848c4760c23805bf993396b19c8b2 (diff) | |
| download | busybox-243d1757d798a0cd43f51eb1db75cc1e81c65732.tar.gz | |
remove some dead assignments, add a TODO comment
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
| -rw-r--r-- | archival/libunarchive/data_extract_all.c | 1 | ||||
| -rw-r--r-- | editors/vi.c | 1 | ||||
| -rw-r--r-- | networking/udhcp/dhcprelay.c | 3 |
3 files changed, 2 insertions, 3 deletions
diff --git a/archival/libunarchive/data_extract_all.c b/archival/libunarchive/data_extract_all.c index c4ffe7ef8..00e67d405 100644 --- a/archival/libunarchive/data_extract_all.c +++ b/archival/libunarchive/data_extract_all.c @@ -127,6 +127,7 @@ void FAST_FUNC data_extract_all(archive_handle_t *archive_handle) break; case S_IFLNK: /* Symlink */ +//TODO: what if file_header->link_target == NULL (say, corrupted tarball?) res = symlink(file_header->link_target, file_header->name); if ((res == -1) && !(archive_handle->ah_flags & ARCHIVE_EXTRACT_QUIET) diff --git a/editors/vi.c b/editors/vi.c index 9b050e115..0f412c362 100644 --- a/editors/vi.c +++ b/editors/vi.c @@ -2385,7 +2385,6 @@ static int file_write(char *fn, char *first, char *last) status_line_bold("No current filename"); return -2; } - charcnt = 0; /* By popular request we do not open file with O_TRUNC, * but instead ftruncate() it _after_ successful write. * Might reduce amount of data lost on power fail etc. diff --git a/networking/udhcp/dhcprelay.c b/networking/udhcp/dhcprelay.c index e14325dca..d194a989b 100644 --- a/networking/udhcp/dhcprelay.c +++ b/networking/udhcp/dhcprelay.c @@ -175,7 +175,6 @@ static void pass_to_server(struct dhcp_packet *p, int packet_len, int client, in struct sockaddr_in *client_addr, struct sockaddr_in *server_addr) { int res, type; - struct xid_item *item; /* check packet_type */ type = get_dhcp_packet_type(p); @@ -187,7 +186,7 @@ static void pass_to_server(struct dhcp_packet *p, int packet_len, int client, in } /* create new xid entry */ - item = xid_add(p->xid, client_addr, client); + xid_add(p->xid, client_addr, client); /* forward request to LAN (server) */ errno = 0; |