aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenys Vlasenko <vda.linux@googlemail.com>2017-08-06 21:47:07 +0200
committerDenys Vlasenko <vda.linux@googlemail.com>2017-08-06 21:47:07 +0200
commit9536ef7c9855172d25223242eba7b7692339e3d8 (patch)
tree4fd644f44af938aa379a82cbbca957e972c687ce
parent7389662dbf54463222d66e555368e0151098ab38 (diff)
downloadbusybox-9536ef7c9855172d25223242eba7b7692339e3d8.tar.gz
makedevs: make it NOEXEC
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r--NOFORK_NOEXEC.lst6
-rw-r--r--miscutils/makedevs.c2
2 files changed, 4 insertions, 4 deletions
diff --git a/NOFORK_NOEXEC.lst b/NOFORK_NOEXEC.lst
index fb76fcf63..63ec08643 100644
--- a/NOFORK_NOEXEC.lst
+++ b/NOFORK_NOEXEC.lst
@@ -127,7 +127,7 @@ findfs - suid
flash_eraseall
flash_lock
flash_unlock
-flashcp - needs ^C. flash writing may be slow, better to free memory memory by execing
+flashcp - needs ^C. flash writing may be slow, better to free memory by execing
flock - spawner, changes state (file locks), let's play safe and not be noexec
fold - noexec. runner
free - nofork candidate(struct globals, needs to close /proc/meminfo fd)
@@ -214,7 +214,7 @@ lzcat - runner
lzma - runner
lzop - runner
lzopcat - runner
-makedevs
+makedevs - noexec
makemime - runner
man - spawner, interactive, longterm
md5sum - noexec. runner
@@ -278,7 +278,7 @@ raidautorun - noexec. very simple. leaks: open+xioctl
rdate - needs ^C (may talk to DNS servers, which may be down)
rdev - leaks: find_block_device -> readdir+xstrdup
readlink - NOFORK
-readprofile - reads /boot/System.map and /proc/profile, better to free more memory memory by execing?
+readprofile - reads /boot/System.map and /proc/profile, better to free more memory by execing?
realpath - NOFORK
reboot - rare
reformime - runner
diff --git a/miscutils/makedevs.c b/miscutils/makedevs.c
index c2f86df01..c13ad1442 100644
--- a/miscutils/makedevs.c
+++ b/miscutils/makedevs.c
@@ -38,7 +38,7 @@
//config:
//config:endchoice
-//applet:IF_MAKEDEVS(APPLET(makedevs, BB_DIR_SBIN, BB_SUID_DROP))
+//applet:IF_MAKEDEVS(APPLET_NOEXEC(makedevs, makedevs, BB_DIR_SBIN, BB_SUID_DROP, makedevs))
//kbuild:lib-$(CONFIG_MAKEDEVS) += makedevs.o