aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorElliott Hughes <enh@google.com>2017-02-17 14:43:56 -0800
committerRob Landley <rob@landley.net>2017-02-17 22:29:03 -0600
commit18cd02cc3e6529bcd3c8bcdf005e78925a320e35 (patch)
treeb30c90bb380da36a5a2b2c696229e2b1c2ad87bf
parentaf92dfdad8b8f2e8d35a1959832a3b6939261d9f (diff)
downloadtoybox-18cd02cc3e6529bcd3c8bcdf005e78925a320e35.tar.gz
Fix the comment about the Android SIGPIPE behavior.
-rw-r--r--main.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/main.c b/main.c
index a2267dab..d05cbfe8 100644
--- a/main.c
+++ b/main.c
@@ -213,8 +213,12 @@ int main(int argc, char *argv[])
}
*argv = getbasename(*argv);
- // Bionic's dynamic linker adds a handler to report SIGPIPE as an error,
- // then doesn't want that behavior for toybox. So disable it for bionic.
+ // Up to and including Android M, bionic's dynamic linker added a handler to
+ // cause a crash dump on SIGPIPE. That was removed in Android N, but adbd
+ // was still setting the SIGPIPE disposition to SIG_IGN, and its children
+ // were inheriting that. In Android O, adbd is fixed, but manually asking
+ // for the default disposition is harmless, and it'll be a long time before
+ // no one's using anything older than O!
if (CFG_TOYBOX_ON_ANDROID) signal(SIGPIPE, SIG_DFL);
// If nommu can't fork, special reentry path.