aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorElliott Hughes <enh@google.com>2019-07-01 14:50:10 -0700
committerRob Landley <rob@landley.net>2019-07-06 16:13:13 -0500
commit3d8bbdc83d8b4891c1b887942e054974eb6291b7 (patch)
treedd6328c5c45a05cd3492778f15a4f01fdcaf054e
parent6a63b625bfa2c0e86c18ccb5bdc71010e24c9829 (diff)
downloadtoybox-3d8bbdc83d8b4891c1b887942e054974eb6291b7.tar.gz
ifconfig.test: disable the pointopoint tests.
These tests don't work for me as root on either my Debian desktop or my Android devices. The original mail thread implies that they were as close as the original comitter could get to _something_ that seemed to work, even if the kernel doesn't seem to bother with this: http://lists.landley.net/pipermail/toybox-landley.net/2014-November/003795.html toybox ifconfig *is* missing support for `-pointtopoint` and `pointopoint` (without an addess), similar for `broadcast` according to the man page. But since we don't appear to have a way to test this (other than looking at strace output!) I'm leaning towards YAGNI anyway...
-rwxr-xr-xtests/ifconfig.test14
1 files changed, 8 insertions, 6 deletions
diff --git a/tests/ifconfig.test b/tests/ifconfig.test
index 34b84b73..d71f3576 100755
--- a/tests/ifconfig.test
+++ b/tests/ifconfig.test
@@ -123,16 +123,18 @@ testing "dummy0 arp down" \
# Test Description: Call the pointopoint option with no argument
# Results Expected: After calling ifconfig dummy0, there is one line with the
# NOARP and UP flags
-testing "dummy0 pointopoint" \
-"ifconfig dummy0 pointopoint && ifconfig dummy0 | grep -i NOARP | grep -i UP | wc -l" \
-"1\n" "" ""
+# TODO: http://lists.landley.net/pipermail/toybox-landley.net/2014-November/003795.html
+#testing "dummy0 pointopoint" \
+#"ifconfig dummy0 pointopoint && ifconfig dummy0 | grep -i NOARP | grep -i UP | wc -l" \
+#"1\n" "" ""
# Test Description: Test the pointopoint option and set the ipaddress
# Results Expected: After calling ifconfig dummy0, there is one line with the
# word inet and the selected ip address
-testing "dummy0 pointopoint 127.0.0.2" \
-"ifconfig dummy0 pointopoint 127.0.0.2 && ifconfig dummy0 | grep -i inet | grep -i 127\.0\.0\.2 | wc -l" \
-"1\n" "" ""
+# TODO: http://lists.landley.net/pipermail/toybox-landley.net/2014-November/003795.html
+#testing "dummy0 pointopoint 127.0.0.2" \
+#"ifconfig dummy0 pointopoint 127.0.0.2 && ifconfig dummy0 | grep -i inet | grep -i 127\.0\.0\.2 | wc -l" \
+#"1\n" "" ""
####### Flags you can set on an interface (or -remove by prefixing with -): ###############